Takeshi Yoneda
Takeshi Yoneda
well this doesn't work as well - ``` vscode@mathetake-Venus-series:/workspaces/envoy$ bazel test --define wasm=none //test/integration:tcp_proxy_integration_test ERROR: /workspaces/envoy/test/integration/BUILD:1750:24: in cc_test rule //test/integration:tcp_proxy_integration_test: target '//source/extensions/formatter/metadata:config' is not visible from target '//test/integration:tcp_proxy_integration_test'. Check the...
so ```diff diff --git a/source/extensions/formatter/metadata/BUILD b/source/extensions/formatter/metadata/BUILD index 8d1bf6bf39..78a8e7d86b 100644 --- a/source/extensions/formatter/metadata/BUILD +++ b/source/extensions/formatter/metadata/BUILD @@ -23,6 +23,10 @@ envoy_cc_extension( name = "config", srcs = ["config.cc"], hdrs = ["config.h"], + extra_visibility =...
thank you for clarifying. So I think my last commit https://github.com/envoyproxy/envoy/commit/747b64282442575299f39e4f53e7848f7f5832a3 is the furthest we can get without adding the extra visibility. edited: we could add `test/extensions/formatter/metadata/integration_test.cc` in the first...
the verify test failing looks irrelevant to this PR.
@phlax `verify_examples` wasm-cc is constantly failing all over the places recently. Anyone is working on fixing it?