Takeshi Yoneda

Results 219 comments of Takeshi Yoneda

not sure if this happens with the old compiler in the first place

thank you for your research @ncruces. I think we can conclude that this is some flake in the binary in the first place, I still wonder where does it come...

> I'd like to be able to provide different sets of host functions to each instantiated module. You should be able to achieve this without the importResolve - just use...

https://github.com/envoyproxy/envoy/compare/main...mathetake:envoy:metadatahttpmutation?expand=1 just quickly created a WIP branch for this

So currently, [RateLimitRequest](https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/ratelimit/v3/rls.proto) API assumes that null (== zero in Go level) addend should be interpreted as 1: > (uint32) Rate limit requests can optionally specify the number of hits...

> I would suggest to use per-descriptor hits_addend to replace the per-request hits_addend. Note that every descriptor is evaluated independent anyway. The new per-descriptor hits_addend is more flexible and has...

This is an expected behavior as explicitly documented in https://github.com/tetratelabs/wazero/blob/4231c48a9c9adf451efcacecfd82278cab2c43a4/api/wasm.go#L383-L384 https://github.com/tetratelabs/wazero/blob/4231c48a9c9adf451efcacecfd82278cab2c43a4/api/wasm.go#L451-L452

@wbpcode I will take a shot at this!

https://docs.google.com/document/d/1odMAistdE8OrJHqKvV4ou9vsZxB1Wepy0cxAyBJ-Bes/edit so @arkodg and I quickly wrote a simple proposal. @wbpcode could you take a look when you get a chance? Thanks in advance!