Matan Lurey
Matan Lurey
In order to avoid this blocking the sync, I'll add a work-around for now @alorenzen.
Ping @MichaelRFairhurst @scheglov could I get some help? I added a regression test here: https://github.com/dart-lang/angular/blob/master/_tests/test/regression/908_analyzer_inference_test.dart The skipped case passes externally, but fails internally.
@leafpetersen I tried implementing the simplest repro possible: ```dart import 'provider.dart'; import 'token.dart'; const tokenOfString = const Token(); const implicitProviderOfString = const Provider(tokenOfString); const explicitProviderOfString = const Provider(tokenOfString); ``` ```dart...
@stereotype441 took a look at this. I'm going to port the above test internally, where it fails, and then share with the team to see if we can make some...
From what I can tell... this works fine internally, too. It's likely something very subtle and not directly related to the analyzer, or build, but I really appreciate everyone looking...
I'm closing this, as we are just landing a workaround instead.
Re-opening. Even with the workaround... sometimes it doesn't work :-/
This test fails internally when DDC enforces type checks for `List`: https://github.com/dart-lang/angular/blob/master/_tests/test/core/linker/deferred_component_ngmodel_test.dart ... it shouldn't.
Wow! Thanks @stereotype441! I think I can add a workaround, again, until we have a fix.
Oh sad, it looks like this won't work out of the box on CI due to RBE stuff? ```txt I[21:02:53.409] Compile command from CDB is: [/b/s/w/ir/cache/builder/src/out/host_debug_unopt] /b/s/w/ir/cache/builder/src/buildtools/linux-x64/reclient/rewrapper --cfg=/b/s/w/ir/cache/builder/src/flutter/build/rbe/rewrapper-linux-x64.cfg --exec_root=/b/s/w/ir/cache/builder/src/ --server_address=unix:///b/s/w/ir/x/w/recipe_cleanup/rbe5tdxl4rl/reproxy.sock...