Matan Lurey

Results 365 comments of Matan Lurey
trafficstars

It would be good to tackle this for 5x as I imagine its not too much work.

Probably specify custom elements? Two ideas: 1. Support a `compiler_ignore_tags` (or better name): ```yaml ignore_tags: - "video-player" - "google-sign-in" ``` 2. Support a `compiler_ignore_tags: any` or `compile_ignore_tags: custom-elements` Thoughts? @alorenzen

I could see ignoring tags being good only if you know there are specific pages where you'll use so many dynamic/custom tags that it isn't possible to list them all,...

I think it's unlikely we will get to this by 5.0 at this point.

Use case, what if Twitter for example adds a custom element, `twitter-login`: ```html ``` ... will need to generate ... ```dart void detectChanges() { if (currVal0 != ctx.myEmail) { js.setProp(el0,...

@leonsenft: It looks like while it is good style to reflect properties as attributes, it's not strictly speaking required - for example even the [best practices for Chrome states][1]: >...

@leonsenft and I had a discussion about this last week, and we had several good reasons for _not_ doing this. I wish I wrote them down :). Happy to leave...

I personally like the @alorenzen's suggestion: * It's explicit (you have to declare you want an `@Output()` bubbled up) * It gives a clear, unambiguous syntax to apply transformations, if...

Also lets not conflate creating _delegating_ components with bubbling events (for example this would likely include inputs, not just outputs). We should track the request for delegates elsewhere if possible.

Good question. One thing we discussed was Injection-selection APIs. Here is my idea, as I hate having 4-5 top-level annotations for this purpose: (from https://github.com/dart-lang/angular/pull/1186) ```dart abstract class Inject {...