Martin Liška

Results 334 comments of Martin Liška
trafficstars

> It would be very nice to have gcovr be able to exploit the new gcov JSON output... thanks!! I'm all for it! I think the format seems quite stable.

> Does this work for partial matches? Yes, I've just added partial match support.

I've just added CHANGES, but for a working test, I would need an HTML inspection of rendered `search.html` page. Do we have such tests?

As an improvement, it should be possible to emit a link directly to the title in a page. But I can't find a function that would give me for a...

> In general handling this when building the index is probably better, though given that the HTML must be parsed anyway to handle the snippets I'm not sure. Yes, I...

> Something like `node.parent["names"]` should work? The anchor link is on the `docutils.nodes.section` node as I recall. Yep, that almost works: ```patch diff --git a/sphinx/search/__init__.py b/sphinx/search/__init__.py index bbb28c0b9..7916d26f0 100644 ---...

> Ahh, can you try `["ids"]`? Works for me, added that.

Can you please @AA-Turner review the pull request now?

> The PR only shows 5 results, and doesn't highlight the title, whereas the current master shows the title, albeit as the third result. Yeah, it's a fancy feature of...