Tasos Maroudas comments

Results 16 comments of


Tasos Maroudas

RFC: Targeting support

Hello! Happy holidays and a happy fruitful new year to everyone! Any progress regarding this? I would also like to see this happening and implement in my Android game :smiley:

Status bar height not excluded from screen height in android

Thanks a lot for your contribution @Hinaser . Will have a look and we 'll proceed with that.

Font size doesn't seem to scale well when specifying as a percentage.

@LukasZvikas the idea of using percentages is to have the same percentage for all the devices. Otherwise it doesn't make sense; just go use DP. If you can't make a...

[RN 0.58] removeOrientationListener doesn't remove the listener

Hi there @lschuft and thanks for taking the time to write this detailed post. Sorry I've been a bit busy of the past weeks and reply earlier. Will have a...

[RN 0.58] removeOrientationListener doesn't remove the listener

Hey guys, my time is very limited during this period. I would strongly appreciate if someone could take the time and create a PR for this 👍

[RN 0.58] removeOrientationListener doesn't remove the listener

@AhmedMKamal thanks again for offering a PR :) @lschuft can you have a look as well in order to get this PR ready? Thanks

[RN 0.58] removeOrientationListener doesn't remove the listener

Yes please @lschuft ! 👍

[RN 0.58] removeOrientationListener doesn't remove the listener

Hey @lschuft I know you are busy man, but if you could review here it would be great! Cheers

Fixed an issue where screen height contained status bar in android

Hey @Hinaser @GavricMario and happy new year! Sorry I haven't been active lately. I don't think we should hardcode DP values like `-20`. Any other ideas?

Fix an issue where screenWidth and screenHeight could be zero

Hey @mrigo thanks for the PR! I'm getting a maintainer pretty soon, in order to take over; we 'll have a look :) Thanks again