react-native-responsive-screen icon indicating copy to clipboard operation
react-native-responsive-screen copied to clipboard

Status bar height not excluded from screen height in android

Open Hinaser opened this issue 5 years ago • 2 comments

Hi. I found an issue in height calculation for android. There is a known issue for android height definition.

Reference: https://qiita.com/uutarou10/items/1aad5fd2d03fb54e0dbf

For iOS, height of window and screen is the same.

But for android it isn't. See picture below.

So, for android, we must exclude statusbar height from screenHeight.

I'll soon send a PR to fix this issue.

Hinaser avatar May 13 '19 06:05 Hinaser

Thanks a lot for your contribution @Hinaser . Will have a look and we 'll proceed with that.

marudy avatar May 17 '19 08:05 marudy

Any news about that ? Thanks !

Vaneste avatar Oct 29 '20 09:10 Vaneste