libpysal icon indicating copy to clipboard operation
libpysal copied to clipboard

Does release GHA work?

Open martinfleis opened this issue 3 years ago • 6 comments

I am not sure if the recent release GHA workflow is able to upload to PyPI. See the archive and compare to GitHub releases - https://pypi.org/project/libpysal/#history.

cc @jGaboardi

martinfleis avatar Jan 17 '22 14:01 martinfleis

hmmm. Not able to see the diagnostic from the last time this was run, but both the latest GitHub (v4.5.1.post2) and PyPI v4.5.1 releases were done on 2021/06/27. So it appears that the GHA ran properly for the v4.5.1 release and then simply wasn't run.

Maybe for now we should simply push up the v4.5.1.post2 release to PyPI manually, but we should also consider updating the workflow and adding a manual trigger.

jGaboardi avatar Jan 17 '22 17:01 jGaboardi

Somewhat related to pysal/momepy#307.

jGaboardi avatar Jan 17 '22 17:01 jGaboardi

I think that the 4.5.1 on PyPI is 4.5.1.post2 from here, because there is no other 4.5.1. It seems that those three releases were attempts to make the GHA work.

martinfleis avatar Jan 17 '22 17:01 martinfleis

So does this mean the appropriate tag is not being pushed by the GHA? Or that v4.5.1.post{1,2} are being evaluated as older versions than v4.5.1?

jGaboardi avatar Jan 17 '22 17:01 jGaboardi

Maybe we should release a v4.5.2?

jGaboardi avatar Jan 17 '22 17:01 jGaboardi

It seems that the tag is truncated and .post2 is actually removed before pushing it to PyPI. I just don't know why is that. It doesn't seem to be a versioneer issue.

martinfleis avatar Jan 17 '22 18:01 martinfleis