Martin Evans

Results 252 comments of Martin Evans

Do you think there are any features that LLamaSharp would need to support for you to build plugin/function calling? I think using a Grammar and appropriate prompting should do the...

Can this be split into two parts (in two PRs): 1) Most of the changes you've made here to _enable_ downloading. This would include splitting the config, the dry run...

I haven't gone through this fully in depth, but there's a few minor nitpicks I noticed above. Overall this looks like a good direction. I like the idea to split...

Looks good, thanks for putting this together. Could you please manually trigger a run of the "Update Binaries" action on your repo as a test run. To do that: 1....

@cmpktheo did you ensure you're using the right version of llama.cpp? The C# source is only compatible with one exact version! See the table in the readme [here](https://github.com/SciSharp/LLamaSharp?tab=readme-ov-file#map-of-llamasharp-and-llamacpp-versions) for the...

Since this PR has been stalled for a while I've taken the first step (generating the binaries) and added it in #861, hopefully we can start to make some progress...

Some of this work was pulled out into a separate PR (#861). The rest of the work will need to be updated to fix the conflicts in new PRs, so...

Hopefully I've got the most complex bit out of the way for you with the updated build script :)

My main concern with this PR is the massive amount of extra complexity involved in importing functions. If every single function definition goes from: ```csharp static extern LLamaContextParams llama_context_default_params(); ```...

We could use t4 templates, they're supported in every version of dotnet (since they're a stage that runs before the compiler, not as part of it). I've used them extensively...