Martin Grofčík comments

Results 25 comments of


                                            Martin Grofčík

#3106 plain dmn table key export/import

@tijsrademakers @jbarrez @filiphr : Is there any reason why pull request is not merged?

#3106 plain dmn table key export/import

We are not able to define dmn key in dmnTask. Other tasks which use references allow reference by key. How to solve this problem and inconsistency?

#3106 plain dmn table key export/import

Hi @tijsrademakers, may I ask you for your opinion?

[DmnServiceTask] dmn table key as expression

@tijsrademakers, @jbarrez : Is the pull request OK? Can it be merged to master? Do you see any issue in it?

[DmnServiceTask] dmn table key as expression

Hi @tijsrademakers, there is a precedence: ``` // When decision table key is present, can be still overridden by decision table/service references String decisionModelKey = getPropertyValueAsString(PROPERTY_DECISIONTABLE_REFERENCE_KEY_DEFINITION, elementNode); ``` and tests:...

Flowable Modeler: export/import of BPMN diagram loses the decision table reference

Hi, see: #3106 Regards Martin

#3094 triggerable bpmn error

@tijsrademakers @jbarrez @filiphr : Is there any reason why pull request is not merged?

#3094 triggerable bpmn error

Hi @tijsrademakers, > ServiceTaskFutureJavaDelegateActivityBehavior Are already covered by `catchErrorThrownByTriggerableFutureJavaDelegateProvidedByDelegateExpressionOnServiceTask` . The trigger method invocation is handled by 'ServiceTaskDelegateExpressionActivityBehavior' > ServiceTaskJavaDelegateActivityBehavior Test `classDelegateTriggerBpmnException` and exception is caught by `ClassDelegate`.

#3094 triggerable bpmn error

Hi @filiphr, yes `ActivitiAgenda` was added by mistake during the merge and also `leave`. Fixed now, thanks.

#3094 triggerable bpmn error

@filiphr Is `leave` on the correct place now?