flowable-engine #3094 triggerable bpmn error

Check List:

Unit tests: YES
Documentation: NA

Nov 21 '21 09:11 martin-grofcik

@tijsrademakers @jbarrez @filiphr : Is there any reason why pull request is not merged?

Jan 19 '22 08:01 martin-grofcik

@martin-grofcik this PR is a good improvement, but we are missing the ServiceTaskFutureJavaDelegateActivityBehavior and ServiceTaskJavaDelegateActivityBehavior changes in the same way as you did it now for the expression variant. Can you also make sure unit tests are added for these behaviors as well?

Jan 19 '22 08:01 tijsrademakers

Hi @tijsrademakers,

ServiceTaskFutureJavaDelegateActivityBehavior

Are already covered by catchErrorThrownByTriggerableFutureJavaDelegateProvidedByDelegateExpressionOnServiceTask . The trigger method invocation is handled by 'ServiceTaskDelegateExpressionActivityBehavior'

ServiceTaskJavaDelegateActivityBehavior

Test classDelegateTriggerBpmnException and exception is caught by ClassDelegate.

Feb 06 '22 08:02 martin-grofcik

I went through your changes @martin-grofcik, why did you add the ActivitiAgenda to the flowable-engine module?

Feb 07 '22 07:02 filiphr

Hi @filiphr, yes ActivitiAgenda was added by mistake during the merge and also leave. Fixed now, thanks.

Feb 07 '22 10:02 martin-grofcik

@filiphr Is leave on the correct place now?

Feb 14 '22 07:02 martin-grofcik

@filiphr any update?

Mar 30 '22 07:03 martin-grofcik

As I also worked on BPMNErros for #3452 I looked through the changes and think they are fine as they are now. Would be good to have those in for 6.8.0 to round up the whole BPMNError story.

Oct 12 '22 08:10 arthware