Martin Brennan

Results 14 issues of Martin Brennan

This commit introduces rails system tests run with chromedriver, selenium, and headless chrome to our testing toolbox. To best reflect how the tests are run on CI, you should run...

This will replace `enable_personal_messages` and `min_trust_to_send_messages`, this commit introduces the setting `personal_message_enabled_groups` and uses it in all places that `enable_personal_messages` and `min_trust_to_send_messages` currently apply. A migration is included to set...

See https://meta.discourse.org/t/discourse-email-messages-are-incorrectly-threaded/233499 for thorough reasoning. This commit changes how we generate Message-IDs and do email threading for emails sent from Discourse. The main changes are as follows: * Introduce an...

This commit changes the docked-upload to use the new UppyUploadMixin from discourse core; the old mixin is no longer supported. I also added some minor fixes around changed APIs for...

Redesigns the bookmark modal and adds a new bookmark menu that shows which has preset reminder options and ways to edit/delete the bookmark. This is hidden behind enable_experimental_bookmark_redesign_groups site setting...

i18n

Followup to e113eff6634c9b398b0541ea6a0d1626f6732dcc We previously sanitized input for integer site settings on the server side only, which was a bit confusing when users would enter e.g. 100.5 and end up...

Followup 2f2da7274732cba30d03b6c5c3a4194652cb6783 This commit moves topic view tracking from happening every time a Topic is requested, which is susceptible to inflating numbers of views from web crawlers, to our request...

This commit introduces a little bit of duplication since the old plugin UIs not using the new plugin show page look different from ones like AI and Gamification which have...

i18n