Martin Brennan

icon indicating a website link http://writing.martin-brennan.com icon indicating an email [email protected]

icon company @discourse icon location Sunshine Coast, Queensland icon location software engineer @discourse :keyboard: & fiction writer :writing_hand:

Results 7 comments of Martin Brennan

Resumable uploads with S3 Multipart

Just noting that at some point in the future I would be interested in support for resumable S3 multipart uploads as well!

DEV: Minimal first pass of rails system test setup

I will uncomment all the other test runs before merging this.

FEATURE: Introduce personal_message_enabled_groups setting

> Maybe we move allowPersonalMessages to current user service, in your code it's only code using current user as a param afaict. This way we can compute on current user...

FEATURE: Introduce personal_message_enabled_groups setting

Spec failures unrelated

FEATURE: Overhaul email threading

**NOTE**: I need a migration here to set the `outbound_message_id` for existing posts which have an associated `IncomingEmail` record.

do not require an email in smtp_should_reject handler

Hi @evgeni sorry for the delay in reviewing here. I am not sure what the benefit of doing this would be since everything within the discourse Email::Receiver flow assumes the...

do not require an email in smtp_should_reject handler

> Which will allow admins to actually see those bounces in the interface, versus going hunting down logs somewhere on disk. Plus, it eliminates the weird "internal API error" reject...