Marten Seemann

Results 825 comments of Marten Seemann
trafficstars

@grandcat Any thoughts on this PR? Anything I can do to move this forward?

*Maintainer of go-libp2p here* 👋 This would be **super** valuable for the entire libp2p ecosystem. mplex is a terrible muxer, yet we've been keeping support for it, just because JS...

This project seems to be dead, last commit was 7 months ago. According to the README, it's implementing Google QUIC (although without the crypto, however that's supposed to work), whereas...

Adding the following import fixes the problem: ```go import _ "github.com/coredns/coredns/core/plugin" ``` This should probably be added to the manual (https://coredns.io/2017/07/25/compile-time-enabling-or-disabling-plugins/#build-with-external-golang-source-code).

Dependabot is currently not part of the Unified CI Setup. We haven't actually had any discussion about it yet, maybe we should? Could you open an issue in https://github.com/protocol/.github? For...

Is this orthogonal or an alternative to the idea to put this into Protocol Select?

Apparently that's not it, see #103.

The tests are failing because we're running into the `StressTestTimeout` (60s). It's just that without a decent test framework, we don't get a helpful error message.

@aarshkshah1992 Wouldn't it be better to call this callback **during** the TLS handshake, not after it's finished? We determine the peer's ID in https://github.com/libp2p/go-libp2p-tls/blob/8a8ad624a2911e6557746729a37f641580b3b16a/crypto.go#L79-L104, and we could fail the handshake...