Marten Seemann

Results 802 comments of Marten Seemann

> Does the quic-go API have that ability? If so, we can find a way to expose it in Caddy. quic-go doesn't really care about the port. You pass a...

It should. There's some logic to set the correct ALPN, maybe there's a bug in there? https://github.com/lucas-clemente/quic-go/blob/706a482340141f8edb26fefae993e96b1581b034/http3/server.go#L56-L90

> It looks like tokens in this context are used for "address validation" -- to ensure the client can receive packets at the address they say they are coming from,...

This is probably due to the fact that we can't fill the `tls.ConnectionState` on HTTP/3 requests, see https://github.com/lucas-clemente/quic-go/issues/2879. Any idea how to best proceed here?

The right fix would be to fix `crypto/tls`, such that one can call `ConnectionState()` at any time during the handshake. Unfortunately, that's not an easy thing to do. Alternatively, we...

No, `PeerCertificates` would be something that we'd need to get from crypto/tls.

This is the (stripped down) code I'm using to get the certificate ```go cfg := certmagic.NewDefault() acmeManager := certmagic.NewACMEManager( cfg, certmagic.ACMEManager{ Agreed: true, // Email: "[email protected]", }, ) cfg.Issuers =...

> The prompt can also be avoided with ManageAsync() (but obviously that has other implications). That makes sense. I guess this issue then reduces to #173. Any idea when #150...

That would work, but pollute all my output with `Skipped` messages. I was wondering if you'd consider exposing a `StopTestRun()` method or so.

@grandcat Friendly ping. Could I get a review of this PR?