Marten Seemann

Results 920 comments of Marten Seemann

It would be a breaking change, but that's what we have semver for 🙃 Would be nice to hear from @bt90 and @AudriusButkevicius, who I believe have been using this...

> `InterceptPacket` does seem like a good idea -- I'm happy to provide a patch. @bokysan That would be appreciated - preferably as a separate PR.

Yes, that's the nice thing about the new API. We don't need the queue anymore, so this should simplify things a bit.

Would be nice if you could use branches, and leave your old code here as it was.

Pulling in a fork of the `net` package seems like the worst way possible to solve the problem.

`InterfaceMultiaddrs` is a helper function, which one could argue doesn't belong in this package in the first place, or at least take a `[]net.Addr` as input. It should be absolutely...

This will require some more care, as the config flags have changed.

I hope this would be fine, but I'm wondering if we'd be breaking people's builds.

I think we should do it, and see if it actually breaks builds. If it does, we can just apply a Docker tag to the old image, to give people...