Markus Lehtonen

Results 350 comments of Markus Lehtonen

Had a brainstorming session with @klihub . I think we have an agreement that a full rewrite would be the right thing to do. Some ideas we came up with:...

How does gbp fail in this case? Currently, gbp does not play out nicely with these kind of spec files as it basically ignores (or at least should ignore) the...

Do you have that other patch (that looks like a hack) somewhere? I think it would be trivial to add for "force importing" all patches (i.e. all Patch: tags). The...

> commit_all has an author_info so it should get a committer_info as well. Done

> I spotted one other change that might introduce problems since __build_env would change return type and that gets passed to Popen and Popen's default type for "do nothing" is...

> patch 3 and 4 could move into a separate PR since they're good to go Done > (Have to think about the --edit case a bit more) What are...

ping @agx: any thoughts or comments on this?

/remove-lifecycle stale

Thanks @Atharva-Shinde for the help! I now did the following updates: - synced with the latest KEP template - added graduation criteria - updated test plan - add kep.yaml -...