Improvements to rpm-ch

[marquiz]

Makes it easier to run full unit tests on rpm based systems

[agx]

Hi, thanks for the patches!

• patch 3 and 4 could move into a separate PR since they're good to go (Have to think about the --edit case a bit more)
• -- commit behaves differently from pq --commit (which only commits patches) this is confusing. Can we make it have the same behaviour?
• I'm not sure --tag is useful in pq since it addds even more options while we could use either gbp buildpackage --git-tag or gbp tag

Overall I tried to not add even more options to commands but rather have separate commands (likg gbp tag) since this makes it less confusing for users.

[marquiz]

patch 3 and 4 could move into a separate PR since they're good to go Done

(Have to think about the --edit case a bit more) What are you unsure about? There is already an --edit option, but, it's broken

-- commit behaves differently from pq --commit (which only commits patches) this is confusing. Can we make it have the same behaviour?

What do you think it should commit? Just the changelog? I found it useful to be able to include other changes to the commit (by doing git-add before invoking gbp-rpm-ch)

I'm not sure --tag is useful in pq since it addds even more options while we could use either gbp buildpackage --git-tag or gbp tag

Overall I tried to not add even more options to commands but rather have separate commands (likg gbp tag) since this makes it less confusing for users.

Yes, I basically agree on that. However, the idea behind the committing/tagging options here is that you can automatically include the correct tag name in the changelog entry that you're committing/tagging. The rpm changlog entry has a version revision field and one option is to use the packaging tag there.