Feature/gitrepository

[marquiz]

[agx]

Hi, thanks for splitting this out. commit_all has an author_info so it should get a committer_info as well.

[marquiz]

commit_all has an author_info so it should get a committer_info as well.

Done

[agx]

I spotted one other change that might introduce problems since __build_env would change return type and that gets passed to Popen and Popen's default type for "do nothing" is None not {} (see _execute_child in subprocess.py). I don't think that matter but it might be worth checking.

[marquiz]

I spotted one other change that might introduce problems since __build_env would change return type and that gets passed to Popen and Popen's default type for "do nothing" is None not {} (see _execute_child in subprocess.py). I don't think that matter but it might be worth checking.

Well spotted :) It won't make any difference as the current env is copied in this case. An empty dict is already used in some places, e.g. add_files(). However, I now added one more commit so that extra_env={} will be handled as expected.