Mark Laing

Results 136 comments of Mark Laing

> I'm not sure if we even need cancel.HTTPRequestCanceller anywhere in the code base. Although I notice, with dismay, that its part of the public SDK via BackupFileRequest and ImageFileRequest...

> > introducing a context.Context parameter across the whole client interface > > This has been on the "TODO" list for quite some time too. Shall we bite the bullet?...

This PR is now updated to: 1. Add a context to an operations' main "run" hook. This context contains the operation requestor and can be cancelled in some situations. 2....

Test failures fixed. Opened a new issue for the underlying problem: https://github.com/canonical/lxd/issues/17220

@tomponline tests finally ran and passed. I've also changed the operation delete endpoint to emit the lifecycle event before waiting on the operation. Ready for review when you're ready 😌

> @markylaing btw is `UpdateResources()` unused? I'll check