Mark Laing
Mark Laing
> @markylaing we should also consider the `.URL()` functions in `shared/api/*` and think about if these can be consolidated too. See https://github.com/canonical/lxd/pull/12872#discussion_r1488121382
> @markylaing please can you advise @hamistao if/where we need a an authorizer check when listing storage volumes? As the authorization filtering is occurring at the end of the handler...
I'm not sure why this is failing the compatibility check: - https://github.com/canonical/lxd/actions/runs/8071688009/job/22051847315?pr=12976#step:8:212 - `go: github.com/openfga/[email protected] requires [email protected], but 1.21 is requested` It's I'm using 1.21.7 locally.
I've rebased onto main. Hopefully this looks a lot less daunting to review now :laughing:
While testing I've come across this error: https://github.com/canonical/lxd/actions/runs/8083078860/job/22085325564?pr=12976#step:13:7250 The test isn't catching it but this was caused by the OpenFGA datastore trying to resolve the URL of a permission whose...
> While testing I've come across this error: https://github.com/canonical/lxd/actions/runs/8083078860/job/22085325564?pr=12976#step:13:7250 > > The test isn't catching it but this was caused by the OpenFGA datastore trying to resolve the URL of...
> While testing I've come across this error: https://github.com/canonical/lxd/actions/runs/8083078860/job/22085325564?pr=12976#step:13:7250 > > The test isn't catching it but this was caused by the OpenFGA datastore trying to resolve the URL of...
> @markylaing I was playing around with different permissions and found a potential issue. I created a group with a single permission `can_view_instances` on `project`. Then I allocated this group...
> I suggest to use 403 over 404 when users have no permission. > > ## Consider the scenario: > Alice has no access to `secret-project` on the server In...
> @markylaing I was playing around with different permissions and found a potential issue. I created a group with a single permission `can_view_instances` on `project`. Then I allocated this group...