Mark Laing
Mark Laing
> Code looks great. Perhaps you can get some testing in by using (or creating a variant of) [testRelyingPartySession](https://github.com/zitadel/oidc/blob/7d57aaa99983368527b0fc93f72ab5542b2eefd2/pkg/client/integration_test.go#L63) Great stuff I'll look into doing that and ping you when...
@muhlemmer hi :wave: I've added integration tests now. Tests all ok locally :)
FYI I'll be away until the 17th of June and may not be able to respond or update this PR in the meantime. Apologies!
@muhlemmer good morning :) I'm available to respond to any comments about this PR now. Looking forward to hearing your feedback. Thanks
@muhlemmer is there anything else I can do to help get this over the line? Thanks
> Thanks @markylaing, Tim is on hols atm, he's back in a couple of days, then he'll have a look again! Great stuff thank you :pray:
This makes sense, as you say claims and scopes are different things. I'm not sure about `oidc.additional_scopes` though, because LXD has no need for general additional information that may be...
Hi @ech0-de, This issue is multifaceted so I'll summarise my thinking first: 1. As you say, the `offline_access` scope is included in the OIDC specification, but is marked as optional....
@ech0-de @mrbranan With the addition of the `oidc.scopes` configuration key in #14935 you can now remove `offline_access` and the `oidc.groups.claim` config key is no longer used as a scope. The...
Unfortunately it's not as simple as I thought. The SimpleStreams client does not have a context like the LXD client does. So unless we add that, there would be no...