Markus Bergholz

Results 268 comments of Markus Bergholz

@felixfontein If I remember right, you wanted to implement such feature long time ago :) @danmoz my workaround for this is to keep all your zone records in a var...

Can you also please add an integration test that covers this case? https://github.com/ansible-collections/community.aws/tree/main/tests/integration/targets/opensearch Otherwise LGTM

> @markuman, as far as I can tell, integration tests for `opensearch` are [disabled](https://github.com/ansible-collections/community.aws/blob/2ad8a8ff5b620b6bd2dc57fa9d695c7622e09c11/tests/integration/targets/opensearch/aliases#L22). Ah ok. I'll run the opensearch test locally later this day and give you a feedback.

The current integration test does not work anymore and need more care. ```diff diff --git a/tests/integration/targets/opensearch/defaults/main.yml b/tests/integration/targets/opensearch/defaults/main.yml index da6aef4b..03a5e04f 100644 --- a/tests/integration/targets/opensearch/defaults/main.yml +++ b/tests/integration/targets/opensearch/defaults/main.yml @@ -1,2 +1,5 @@ --- #...

> Does `admin` IAM role exist in the account you're using for testing? No, it doesn't.

> > Does `admin` IAM role exist in the account you're using for testing? > > No, it doesn't. That explained that why the integration test is disabled :smile: >...

> Keep in mind this can only work if all the data endpoints (in style.json) are on the same domain as the style.json address. GpxPod authorizes the domain of the...