Markus Bergholz comments

Results 268 comments of


                                            Markus Bergholz

timeout_in_minutes : Update codebuild_project.py

recheck

using `convert-h5-to-ggml.py` I get this error : FileNotFoundError: [Errno 2] No such file or directory: 'whisper.cpp/whisper/assets/mel_filters.npz'

``` python convert-h5-to-ggml.py ../../tiny-ger/ ../../whisper/ ../../out/ Traceback (most recent call last): File "/home/m/git/lekker/markus.bergholz/tmp/gguf_convert/whisper.cpp/models/convert-h5-to-ggml.py", line 119, in fout.write(struct.pack("i", hparams["max_length"])) ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^ struct.error: required argument is not an integer ``` Basically I try...

using `convert-h5-to-ggml.py` I get this error : FileNotFoundError: [Errno 2] No such file or directory: 'whisper.cpp/whisper/assets/mel_filters.npz'

Ok, this PR solves my issue: https://github.com/ggerganov/whisper.cpp/pull/2840

support for redis7 group family for parameter groups

Can you also add a changelog fragment? Otherwise it looks good to me

support for redis7 group family for parameter groups

it's just that ```diff diff --git a/changelogs/fragments/2254-add-redis7x-cache-parameter-group-family.yml b/changelogs/fragments/2254-add-redis7x-cache-parameter-group-family.yml new file mode 100644 index 00000000..7a97f631 --- /dev/null +++ b/changelogs/fragments/2254-add-redis7x-cache-parameter-group-family.yml @@ -0,0 +1,2 @@ +minor_changes: + - elasticache_parameter_group - add ``redis7.x`` group...

cloudfront_distribution_info summary fails with 'TypeError: CloudFrontFactsServiceManager.describe_cloudfront_property() takes 4 positional arguments but 5 were given'

c.a 5.x.x required a.a >= 5 https://github.com/ansible-collections/community.aws/blob/stable-5/galaxy.yml#L12 Maybe it must also exclude a.a. < 6.

cloudfront_distribution_info summary fails with 'TypeError: CloudFrontFactsServiceManager.describe_cloudfront_property() takes 4 positional arguments but 5 were given'

I cannot reproduce your error. > TypeError: describe_cloudfront_property() takes 4 positional arguments but 5 were given The function `describe_cloudfront_property()` was introduced in amazon.aws.6.0.0 https://github.com/ansible-collections/amazon.aws/blob/6.0.0/plugins/module_utils/cloudfront_facts.py#L108 And since it exists, it always...

cloudfront_distribution_info summary fails with 'TypeError: CloudFrontFactsServiceManager.describe_cloudfront_property() takes 4 positional arguments but 5 were given'

I don't get it why the error is happen. And in any case, this is an issue for amazon.aws collection. Because the error happen while calling line 159 https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/cloudfront_facts.py#L159C9-L159C76 ```py...

Proposal of potential modules to be promoted from community.aws

> Getting us closer to being able to set up a "base" AWS environment through amazon.aws: "base" is difficult to define. Is it just network, servers and dns? > Here...

ec2_launch_template: Add option to define custom throughput

@KamilBlaz thank you very much for your contribution. Your PR needs at least a changelog fragment. Furthermore, can you please append the integration test in `tests/integration/targets/ec2_launch_template/`? otherwise looks good to...