Mark Story
Mark Story
> Then all the plugin's bootstraps are executed, the routes loaded and static calls done (e.g. those TypeFactory adjustments). But that cannot be the solution I guess. I agree that...
> For apps a more global/central place to toggle on would make sense. > Then the app and its tests are more closely related to the actual (non test) behavior....
It would be ideal to have rector rules to help with updating application and plugin logic for these changes.
> My Code: Is there more to your code? How does your `$data` instance get attached to the request?
> It's unlikely anyone is going to implement the CollectionInterface without using the CollectionTrait. So far that has held true.
I agree with ADmad that folks are unlikely to test RC versions. However, I don't think this should merge until we're closer to doing the final release. How about after...
I think this is doable now that we're using rector more. I can help with rector rules if you'd like.
What rulesets would we be running rector against?
@T-Kisaku Could you take a look at #17761? I'm not able to reproduce the corruption issue and I want to know if there is something I'm missing. Perhaps we have...
> Looks like we pass all names through Inflector::underscore(). @markstory I assume this is required for plugins? It isn't required, but command names have to all end up in `CommandCollection`....