Mark Story
Mark Story
I think you have the steps planned out well. Do you think it would be possible for the framework to detect if commands have `ConsoleIoInterface|ConsoleIo` and `Arguments` as constructor parameters...
> Instead of bloating the constructor couldn't those properties just always be set by the CommandRunner? This would make method signature in the CommandRunner cleaner as well. Like with setter...
> then how about we add the arguments and io object to the container? then they will be injected automatically if the constructor has that signature (and the command gets...
Closing for now. If there is any follow up we can reopen.
Looks good to me. Should we also consider deprecating/removing the entity attribute given the ergonomic issues it creates?
The hidden block ensures that the hidden inputs stay hidden, and don't take up any visual space. If you're in a strict CSP environment, you could use custom form helper...
> Sometimes CSS libs/devs add some default styling to all inputs which can potentially add spacing around hidden inputs too for e.g. This is the reason for the hidden div....
Why are you attempting to save records with id=null?
Yeah, I would like to see the a minimal table class (or a big one) that could help reproduce this issue. I'm interested in knowing how to reproduce this so...
@saraer It could be, that issue was 11 years ago. The test that was added then is still around, so it isn't a direct regression.