Mark Story comments

Results 653 comments of


                                            Mark Story

setTemplate {{name}} not populating in Form helper

Moving to enhancement, as `name` has never been an available variable for `inputContainer` or `error` templates.

Unify array structure for containing and marshaling associated data

> In 6.x we could then think about removing one of the different declarations. How? It seems like only one of them provides the full feature set. The other forms...

Unify array structure for containing and marshaling associated data

I can agree that ```php $usersQuery->contain([ 'Articles' => [ 'conditions' => [.....], // option key 'Comments', // model alias ], ]); ``` is awkward. I'm on-board for not having that...

ORM: Optimize eager loading 1:N associations using CTEs to replace WHERE IN (...)

> This would likely need to be an opt-in strategy (e.g., 'strategy' => 'cte') or automatically detected based on DB driver capabilities, as older database versions (like MySQL 5.7) do...

ORM: Optimize eager loading 1:N associations using CTEs to replace WHERE IN (...)

I like the idea of a loader strategy for this. I agree that it could help greatly with improving performance in many scenarios.

Remove argument overloading from RouteBuilder methods

> So you want: Yes. Two reasons. First, this gives people a simple way to upgrade in 5.x without interruption. Second, I think it helps remind developers what is expected/possible...

RFC: 6.x: Use public/ instead of webroot/

I'm on-board with this change :+1:

RFC: 6.x: Use public/ instead of webroot/

Thought about this a bit more, what happens with plugins, and the core command line tools for moving webroot files around? Do those start to support both `public` and `webroot`?

Unable to `contain()` same table multiple times using different aliases

> Is there anything we want to do here? I don't have any immediate actions on this. I agree it is unexpected behavior that should be corrected. But I'm also...

Ability to add `skipCheckCallback()` to CSRF middleware from within a plugin?

I don't think you need to re-insert the middleware back into the queue. You could just add the `skipCallback()` in place. With the `insertAt()` call you're likely getting two copies...