Mark Phelps

Results 105 comments of Mark Phelps

I added the `needs_docs` label just so we don't forget to update the [docs](https://github.com/flipt-io/docs) before creating a new release with this feature included don't feel like you need to add...

with LinkedIn branded colors for testing! ![CleanShot 2024-05-31 at 15 17 26](https://github.com/flipt-io/flipt/assets/209477/839c317c-c9e9-406b-9d4a-0670ac4e2fa5)

> Where did we end up on the stance of using the existing zap logger instead? > > As in, instead of using a JSON encoder over STDOUT, just adapt...

I've now tried switching to use a new zap logger for this functionality, seems promising: ```console {"T":"2024-06-05T10:37:59-04:00","M":"audit","event":{"version":"0.1","type":"flag","action":"updated","metadata":{"actor":{"authentication":"none","ip":"127.0.0.1"}},"payload":{"description":"Testing newest framework of the week","enabled":true,"key":"beta-new-ui-framework","name":"beta-new-ui-framework","namespace_key":"default"},"timestamp":"2024-06-05T10:37:59-04:00"}} ```

> I've now tried switching to use a new zap logger for this functionality, seems promising: > > ``` > {"T":"2024-06-05T10:37:59-04:00","M":"audit","event":{"version":"0.1","type":"flag","action":"updated","metadata":{"actor":{"authentication":"none","ip":"127.0.0.1"}},"payload":{"description":"Testing newest framework of the week","enabled":true,"key":"beta-new-ui-framework","name":"beta-new-ui-framework","namespace_key":"default"},"timestamp":"2024-06-05T10:37:59-04:00"}} > ``` The only...

I got it a bit closer when using file based logging: ```json { "event": { "version": "0.1", "type": "flag", "action": "updated", "metadata": { "actor": { "authentication": "none", "ip": "127.0.0.1" }...

Here's what the console log looks like: ```console 2024-06-05T11:37:56-04:00 AUDIT {"event": {"version":"0.1","type":"flag","action":"updated","metadata":{"actor":{"authentication":"none","ip":"127.0.0.1"}},"payload":{"description":"Manages the rollout of updates to our IoT devices","enabled":false,"key":"iot-deviceUpdateControl","name":"iot-deviceUpdateControl","namespace_key":"default"},"timestamp":"2024-06-05T11:37:56-04:00"}} ```

ok, I think this is ready for another round of comments, im going to be adding tests as well /cc @erka @GeorgeMac