flipt icon indicating copy to clipboard operation
flipt copied to clipboard

feat(ui): allow change top bar theme color

Open erka opened this issue 1 year ago • 1 comments

erka avatar May 28 '24 14:05 erka

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.72%. Comparing base (f997fb9) to head (4b73eb1). Report is 378 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   70.78%   71.72%   +0.93%     
==========================================
  Files          91      106      +15     
  Lines        8729     7862     -867     
==========================================
- Hits         6179     5639     -540     
+ Misses       2165     1784     -381     
- Partials      385      439      +54     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '24 15:05 codecov[bot]

I don't have a good place for label. I suggest to modify the page title with the custom label as a temporary solution.

erka avatar May 31 '24 18:05 erka

with LinkedIn branded colors for testing!

CleanShot 2024-05-31 at 15 17 26

markphelps avatar May 31 '24 19:05 markphelps

Thanks @erka ! Are you planning on adding the label to the topbar?

danilobuerger avatar Jun 14 '24 08:06 danilobuerger

Are you planning on adding the label to the topbar?

@danilobuerger Thank you for reaching out. Yes, we are considering adding the label to the topbar. However, we haven't finalized the exact placement yet. If you have any preferences or suggestions on where you'd like to see it, we'd love to hear your thoughts.

erka avatar Jun 14 '24 14:06 erka

@erka Thats awesome! I don't really have a suggestion on the placement, just that it should be big and visible (for example displaying "Warning - Production").

danilobuerger avatar Jun 14 '24 21:06 danilobuerger