Marko Kreen

Results 41 comments of Marko Kreen

Thanks. One more issue - the method name `is_issued_by()` seem not match the implementation. From name I would expect boolean function instead, without verify: ``` def is_issued_by(self, issuer_candiate): return issuer_candidate.subject...

I would be happy to add 7z as backend, the problem is that is does not have "decompress to stdout" option which is critical for `rarfile`. unrar-free has same problem...

`Exception` class is not quaranteed to have `errno` field, it can crash on access. What other type of exceptions have `errno`, but are not `OSError`?

How about a optional "catagory" key, so clients can make broad decision and servers are testable whether right check triggered? Enumerating individual errors seems lot of work, for dubious benefit....

``code`` is fine as a key. The question is can other implementations reproduce them. Main goal is spec regression tests that can be run over several implementations. It's fine to...

Hardwiring chapter numbers as errors seems wrong, both implementations side and also spec side: one-chapter-per-error may be annoying to maintain, especially if you are not allowed to refactor. Named errors...

The testsuite itself would indeed be tied to specific spec version, so instead it makes sense for tests to contain spec section numbers and even links to spec. I still...

Sorry for the wait. I'm trying to push 1.7 out, then deal with new features.

Don't use accept_cancel_request() directly, it does lot of juggling to get server connection, you already have it. Move the part that operates on server connection to separate function and use...

accept_cancel_request() already deals with it