rarfile icon indicating copy to clipboard operation
rarfile copied to clipboard

Modify try-except block to handle any exception with appropriate errno

Open djsigmann opened this issue 3 years ago • 1 comments

djsigmann avatar Mar 04 '22 16:03 djsigmann

Exception class is not quaranteed to have errno field, it can crash on access.

What other type of exceptions have errno, but are not OSError?

markokr avatar Aug 05 '22 16:08 markokr

Exception class is not quaranteed to have errno field, it can crash on access.

What other type of exceptions have errno, but are not OSError?

I'm not sure, AFAIK all the built-in Exceptions do, I'd have to look at the source code to see whether or not subprocess.Popen can raise any exceptions without an errno property.

That being said, it solved any issues I had (on Linux). I might make a quick rewrite that can handle exceptions without an errno property later today if I have time.

djsigmann avatar Nov 14 '22 10:11 djsigmann

This is not good enough to apply as-is. Please find out what sort of exception instance caused the problem, then you can reopen the issue with specific problem we can solve.

markokr avatar Sep 17 '23 11:09 markokr