Mark Koh

Results 13 comments of Mark Koh

hey @loisaidasam thank you for reporting, that result definitely shouldn't be happening! We've seen similar behavior when accidentally adding vectors with `NaN` values into the index, but I don't think...

Moving discussion about this from #64 to here. Relevant comments: [From @markkohdev](https://github.com/spotify/voyager/pull/64#pullrequestreview-1969665955) > In regards to upserting, after chatting with @dylanrb123 about this change, we don't think that this approach...

As mentioned above, how we would probably want to see this implemented is a bit complicated as there are performance/memory implications for this to be enabled. Let's start with how...

Additionally, we should support string index [containment checking](https://spotify.github.io/voyager/python/reference.html#voyager.Index.__contains__) with this python StringIndex as well so that we can write things like ```python if "some-string-key" in my_index: # Do something ```

Looks like this happens with `query()` as well ![image](https://github.com/spotify/voyager/assets/1663379/f0e7c7fd-f4ad-4e7b-9f15-8c86c1c81707)

@eXamadeus thanks for highlighting this! Your issue isn't exactly the same thing, but it's close enough that I can try to fix both of these at once when I'm done...