Mark IJbema

Add trivia?

2

https://github.com/jbrains/trivia

renamed the readme so it will be parsed with markdown again.

Html approver mangles html with boolean attributes

9

the following (valid) html: ``` html Hoi yo ``` becomes this: ``` html window.FactlinkProxiedUri = "http://www.example.org/foo?bar=baz";defer src="http://localhost:8000/lib/dist/factlink_loader.js?o=proxy" onload="__internalFactlinkState('proxyLoaded')" > ```

Approvals.verify(baz, format: 'html') should raise an execption, instead of silently verifying as text.

BinaryWriter

5

What's the status of BinaryWriter? Is it still used? If I comment the whole file out, not a single test fails, and 'BinaryWriter' is mentioned nowhere else in the source.

Update readme

10

I was browsing around the code and am amazed at the amount of functionality which I didn't see from the readme. I think it would be really worthwhile to update...

Redifine match behaviour for filters?

1

I wonder why the choice was made to make a filter match regularly, instead of requiring it to match the whole string. Compare: ``` ruby filters = { time: /^time$/,...

A hash ( # ) should not be stripped from approval name

3

I noticed I test a lot of controller actions, so my names tend to be something like "blogposts#show.json should stay the same" I think we can do better handling of...