Mark IJbema

Results 26 comments of Mark IJbema

It seems to me the question is answered by @nishanthan144, so the issue can be closed.

The props don't change, but their contents can change. So you pass a user. The user doesn't change, but his avatar_url might. In general the philosophy of backbone is a...

Good idea; could you make a pull-request on the readme?

I agree, I think we shouldn'the make promises on updating synchronously (react doesn'the really do this either). A warning would help. I'm not sure on making model asynchronous as well....

Seems like an extension point. Default is force update, but if you override onModelChange, that's called instead. If this isn't in the docs, lets keep this issue open until it...

It has been here since the very first commit. If you want to remove it, I think we should at least add a deprecation warning: https://github.com/clayallsopp/react.backbone/commit/c15403e1bd66d7ad53931166dad472164ed0df17 @clayallsopp do you remember...

I don't think this does stuff in the right order. It only subscribes at moments the component should update, but it updates at any time, regardless of the shouldComponentUpdate. If...

To be clear, I think this implementation is faulty. For instance, lets say you have an optimization that makes the component not update in the first few seconds of the...

I mean adding it to this condition: https://github.com/medyo/react.backbone/blob/master/react.backbone.js#L36

This changes two things: it adds the should-component update, and it changes the compatibility with react version. The createFactory is 'new' in react, so this won't work in older versions....