Mark Nelson

Results 41 comments of Mark Nelson

Hi, That would be great!

Hrm, I think perhaps we should have a flag here. One of the things that we've used CBT for in the past is to let a set of tests run,...

@YiteGu @ifed01 I'm a little terrified of this PR to be honest. :) It feels like we are sort of hijacking the recovery process here in ways it wasn't really...

Hi, sorry for the long delay! It's been a little while since I looked at this code. Is the basic gist of it here that we aren't actually doing the...

Ok, would you be willing to see if the ReadToEnd() idea works? I agree regarding the stats. Thanks!

Agreed. Hit this when copy/pasting content from one etherpad to another. Not only did the new pad silently fail to copy the text, but after deleting the text from the...

@jianwei1216 this looks very interesting! I'll try to take a look soon.

@jianwei1216 I've done some testing on the PR using a 30 NVMe cluster with 3X replication using librbd. So far I'm not seeing much difference with this commit applied, but...

@jianwei1216 In my NVMe tests, would a reasonable hypothesis be that we're serving requests fast enough not to hit the throttle?

@jianwei1216 ah! ok. I don't have an HDD test bed handy at the moment. I'm really surprised that you were seeing ~100% CPU time in the msgr threads on an...