cbt icon indicating copy to clipboard operation
cbt copied to clipboard

Update rbdfio cleanup

Open wadeholler opened this issue 10 years ago • 2 comments

Devices could be left in a stale state on the clients because there was no cleanup in benchmark rbdfio. This could result in later, other benchmark runs failing during their sync step on the clients.

Updated with steps: umount rbd unmap rbd rm

wadeholler avatar Nov 19 '15 20:11 wadeholler

Hrm, I think perhaps we should have a flag here. One of the things that we've used CBT for in the past is to let a set of tests run, look at the results, and then run new tests by hand after the tests complete to track down performance anomalies. Perhaps it makes sense though to have the default behavior be to cleanup the rbd mount points to avoid this kind of issue and only leave the mount points enabled if some kind of "no_cleanup" flag is passed or something.

markhpc avatar Feb 15 '16 16:02 markhpc

In the librbdfio benchmark we have use_existing_volumes. The problem with use_existing_volumes is it doesn't create the volumes if they already exist. Ideally there would be an option where it creates and initializes the volumes if they don't exist, but skips those steps if they do, while also not cleaning up.

mmgaggle avatar Mar 01 '16 17:03 mmgaggle