Mark Erikson

Results 1264 comments of Mark Erikson

FWIW, I've cloned the repo and am currently playing around with trying to do the conversion. Honestly, the biggest problem atm appears to be the heavy reliance on `import *...

Another point in favor of switching to RTK: the current setup adds `redux-thunk` and `redux-immutable-state-invariant`, which RTK already adds to its store setup by default.

PR is up. I made some additional stylistic-ish changes. I'd appreciate it if you'd consider them, but you may ignore them if desired. Also, there's some prior discussion on the...

@kwelch : right, it's not complete. I just wanted to show the basic pattern so that you folks would have that to work from, and you can complete the conversion...

@coryhouse : per the earlier comment, I didn't try to clean up all the other existing logic, and I wasn't sure if there were other aspects of the codebase that...

Yep, seeing this as well when trying to edit and tweak Markdown files in various PRs. Would be great to see this fixed!

So lemme see if I understand what you're actually doing here: - You _are_ putting the store state into context - However, because of the `changedBits` usage, no context consumers...

Ah, good catch! I thought there might be some special handling there, but I hadn't dug into the code to see if that was actually the case. I'd still expect...

Imagine a scenario where a state change would actually cause, say, 10% of the components to re-render. With direct subscriptions, 100% of subscriber callbacks run, but only 10% of the...

Huh. @dai-shi , check out this RFC for React context changes by @gnoff : https://github.com/gnoff/rfcs/pull/2