Mark Erikson

Results 1264 comments of Mark Erikson

+1's aren't really helpful at this point :) That said, perhaps a good way to implement this might be a separate "monitor" panel?

Fixed by #32, mostly, and I'll do some more tweaks.

I take that back. #32 was just the slice. We could still use some tests for the `Counter` component, but I don't feel like writing them atm.

Hmm. I'm not sure if it is or not. `$CombinedState` is a Redux core type.

Yeah. What we really need is **a complete project that actually reproduces the problem and shows this error happening**. Without that, there really isn't anything we can do.

We definitely iterated on the Reselect TS typings between 4.1.0 and 4.1.5. 4.1.5 should be "correct" behavior. Test against that.

We _really_ need a repro at this point :( I'd also like to know if this happens with Reselect by itself as well. (tbh I don't have much time to...

Oh, yeah, you should never actually use `DefaultRootState` in practice. That type was added to the community types years ago, and tbh I don't even know why it's there. It...

Hmm. Okay, this does seem to be RTK-related somehow. I tried switching the example over to use `RootState`, and the error persists: ```ts import { createSelector } from "@reduxjs/toolkit"; //...

Mmm... actually, if this is related to `preloadedState`... didn't we _use_ to declare that it was `DeepPartial`, and then removed that because it actually isn't (ie, you can only provide...