Mark Erikson

Lenz is tossing around ideas for maybe having some form of selectors built into `createSlice`, and also maybe a `combineSlices` helper: - #2776

It's certainly _possible_. As my mentor has said many times: "We can do anything - it's just software!" :) What is probably needed is allowing passing a regex instead of...

@3imed-jaberi I appreciate the enthusiasm, but I would appreciate it if you _didn't_ go through all of our PRs and leave "+1 approve" comments on them :) It adds to...

Yeah, I do appreciate the spirit :) But, tbh generally other folks don't have the context to properly review these PRs. Like, in this case, the changes in this PR...

Looking at https://sourcegraph.com/search?q=context:global+getRunningOperationPromise+-repo:reduxjs+-repo:phryneas+-file:node_modules+-language:markdown&patternType=standard , I can only see 14 actual uses of `getRunningOperationPromise[s]` in the wild. That's small enough that I'm okay with calling this a minor version change even...

Huh. I'm not sure this PR is actually running any tests properly. I just did a rebase against `v1.9-integration`, and removed the "add/revert" commits in the middle. Looks like it's...

Ok, think I've got the tests updated to match what the current implementation logic is actually doing. Need to think about the "request in flight case" still, but at least...

So right now it looks like we're actually hitting this check inside of `queryThunk` if you attempt to call `upsertQueryData` while a request is in flight: ```ts // Don't retry...

Okay. This runs, tests pass, it compiles clean. Let's merge this in and put out `1.9.0-alpha.1` so people can try it out, and we can tweak the edge case behavior...

Huh, weird. Unfortunately I don't think we're going to have any way to investigate this without seeing a repo that demonstrates the problem.