Mark Erikson

Results 1283 comments of Mark Erikson

Nah, that's a docs issue. I think the original contributed draft PR started by copy-pasting some of the lazy query trigger logic and setup, so pretty sure that's just a...

Yeah, off the top of my head, pretty sure the fetch page methods are dispatching the `initiate()` thunk, so it does make sense the resulting actions would trigger the lifecycle...

Interesting. I'd assume this is probably about the reimplementation of the patch generation logic. Can you capture the generated patch action contents and post them? (maybe even diff them to...

I took a stab at reproducing this on the Immer side, and can't. If you can provide a repro or more details I can try to look further.

Trying to recreate these myself again. I _think_ I've recreated @chrisnojima 's issue with Zustand, Immer, and `Map/Set`. I still can't recreate the RTKQ optimistic updates issue.

Bizarrely, I _do_ see the seemingly-broken patch if I run the snack on the web. However, I do _not_ see it if I download the snack, install deps with PNPM,...

Is it at all possible that this is a bundler/minifier issue somehow?

Yeahhhhh, it seems like that might be the case. I've just compared 3 different minified versions: - Working: the Immer section of the prod bundle from building the snack locally...

Okay, filed https://github.com/immerjs/immer/issues/1199 for the array issue, and https://github.com/immerjs/immer/issues/1200 for the `Set` issue.

Awright, looks like this was indeed two separate issues: - Array patches not working: Immer's ESBuild config tries to minify "private" fields like `key_`, but the logic for patch path...