Mark Erikson

Results 1264 comments of Mark Erikson

@rezydent don't think I've heard of that. Can you file a separate issue with a repro? I've tried to avoid making any further changes to `connect` for a while now,...

I filed a PR to add sourcemaps to React's build step in mid-2023 ( #26446 ). That _was_ merged, and for a while the nightly builds had sourcemaps. However, that...

@asvishnyakov does the generated app bundle sourcemap include _any_ file contents for `react-dom-client.production.js`?

@asvishnyakov is that with React 18, or React 19? `react-dom-client.production.js` is a new file in React 19, and doesn't exist in React 19. If I make a new Vite +...

_Strictly_ speaking this bug isn't resolved - my sourcemaps PR got merged and then ripped out before React 19 shipped. The alternative approach was shipping unminified prod builds. This at...

FWIW this could be done with a bit of copy-paste out of the library source to read from the internal state value: ```ts export let isObjectish = (target: any) =>...

I'd say the plugin system is still worth it for the savings in bundle size, so it's a question of whether this ought to be a plugin or not. I'd...

Updates: - Applied some of the PR review changes, like adding a `assignedAllIndices` flag and improving `isArrayIndex` - Converted the array method overrides into a new plugin activated by `enableArrayMethods()`...

Yeah, that's a good question, actually - now that we're _not_ always recursing by default, is there a chance skipping freezing would be valid? There's still several places in the...