Mark Erikson comments

Results 1264 comments of


                                            Mark Erikson

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

I don't understand what you're saying with this sentence: > As for making plain reducers - they don't have all this cool boilerplate of slices, so not sure why not...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

Yeah. To be clear: We _do_ care about performance. We _want_ Redux, RTK, and React-Redux to be as fast as reasonably possible. I personally have put in a lot of...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

@gentlee created my own updated benchmarks example repo at https://github.com/markerikson/immer-perf-tests , which compares both various versions of Immer as well as hand-written reducers and `mutative`, and confirmed that A) Immer...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

@saif-o99 We created the very first prototypes of RTK's `createReducer` with Immer in mind, and it's been based around Immer from day 1. And, at the time, Immer was the...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

Update to this issue: Spent the last few days diving into Immer's codebase and trying to use the benchmark harness I'd built to identify which functions are slow, and then...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

Latest update: I've filed three major perf improvement PRs over in the Immer repo. Combined, they boost Immer perf +30-90% depending on the benchmark scenario, with an average of +57%!...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

Excited to report I've just released Redux Toolkit v2.10.0, which updates to the latest Immer 10.2 to pick up its immutable update perf improvements! Also did a bunch of additional...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

@gentlee I'm not sure what other answers you want from me at this point :) Yes, Immer is always going to be slower than vanilla. That's inherent in the fact...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

Michel Weststrate just released Immer v11, which contains the major architectural rewrite PR I filed to replace Immer's recursive finalization implementation with a more targeted approach: - https://github.com/immerjs/immer/releases/tag/v11.0.0 Based on...

RTK with Immer x100 slower than vanilla Redux at average (up to x400)

@novatech : off the top of my head, I'm not sure of anything in RTK 2.0 that would have degraded app dispatching perf. If you can file a separate discussion...