Mark Erikson

Results 1264 comments of Mark Erikson

Tagging in another report of slow perf for later reference: - https://github.com/reduxjs/redux-toolkit/discussions/4683

@LucasHimelfarb that's an awful lot of JSON, without any context as to what the app is actually intending to do with it. Could you provide an actual runnable reproduction of...

Closing due to lack of a repro for us to look at.

Okay, what I _think_ I'm seeing here is: - Added the configs - A lot of lint fixes, mostly around auto-sorting of imports and forcing type imports - Extracting some...

Can we separate out these changes into multiple PRs? - One to add all the new tooling configs - Second to actually switch to _using_ the configs for testing and...

Unfortunately this looks like it also breaks the light theme: ![image](https://github.com/reduxjs/redux/assets/1128784/022db40f-adde-49ff-82f3-d0d502c6cf62)

Is your concern around the _setup_ part (`createListenerMiddleware()`, `getDefaultMiddleware.concat(listenerMiddleware.middleware)`? Or the "things you can do inside the `effect` callback" part?

@jseaton612 what happens if you turn off the default included devtools enhancer first?

I hear the pain there, but we did intentionally drop UMD builds out of all of the Redux projects a couple years ago due to general lack of usage and...

We'll try to look into this at some point, but realistically both Lenz and I are not going to be actively working on RTK stuff for the next few weeks.