Mark Elliot

Results 64 comments of Mark Elliot

ok, fun. It seems like maybe there's a Java Poet bug here because I'd expect you to be able to refer to `com.foo.Object` by the fully qualified name without any...

In particular, Java Poet probably ought to fully qualify a class reference whenever the class shares a name with something in java.lang

On the producer side, consider creating an (additional) api jar that does not embed its product dependency mapping, and in projects where you manage the dependency ranges yourself, depend on...

There is a release of that (internal) dependency that has a correct range [2.70.x, 3.x.x); ping me over Slack and I think I can point you at it.

I think the fix here is to update the API version that's bad to have improved dependencies. If you pick a version greater than the one that bridges the major...

Something like that? Our general practice is that API jars have ~0 dependencies, so the main thing I’d like to understand is why that’s not true in this case.

actually it's pretty standard for us to break that kind of thing out so that the _API_ dependency is clear.

I believe this was intentional in the original implementation. The library that wraps the dependency needs to redeclare the dependency itself. On May 10, 2018, at 5:03 AM, jroitgrund wrote:...

That file doesn't get rolled. Health checks are typically run by another system which does capture the output, so not sure we should adjust this.

We expect the thing calling the health checks to record the log, notably this shell script does not record the check result in a file but satisfies an API where...