Mark Elliot comments

Results 64 comments of


                                            Mark Elliot

version could be wrong when there are more than 1 tags on the commit

Hm, I’m not sure we can deal with this edge case in a reasonable way. The goal of this (simple) plugin is just to produce a version string equivalent to...

version could be wrong when there are more than 1 tags on the commit

The plugin doesn't require or introspect on the tag format, so while I'd be fine messing with the alphabetic sorting to match `git describe --tags` (would have to request this...

Generate two images?

This plugin does not enable that functionality -- practically speaking we probably ought to move in the direction of making this more like the built-in publishing plugins, where one can...

first-parent problems

Can you talk about your specific workflow? The ones we know about are supported well by this plugin. On Jul 7, 2017, at 20:04, MatthewMaclean wrote: Products often release a...

first-parent problems

Single primary branch, releases are tags that appear on that branch. On Jul 8, 2017, at 00:36, MatthewMaclean wrote: What are the existing workflows + tooling that mesh with --first-parent...

dockerPush doesn't generate (and thus push) all Tags

In the same Gradle file as your Docker block: tasks.dockerPush.dependsOn(tasks.dockerTag)

Make ConcurrencyLimiter's initialLimit configurable

I think we'd prefer to adjust the number rather than make it configurable.

Allow for tildes on exec path if they aren't the start of the path

This hasn’t been an issue to date. Why is it an issue now?

Allow for tildes on exec path if they aren't the start of the path

sorry, could you sketch out a dummy example of the directory tree?

Allow for tildes on exec path if they aren't the start of the path

Ok, instead of running things with the fully resolved path, can we set the execution environment that pokes go-java-launcher to have a base directory, instead?