Omer Yacine

Thanks for replying, Yes most of them are MP3 files, Is there an email i can send the sample file to?

It is Ubuntu 18.04.

@TheModMaker Aha got you. May you please take a look at [this](https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-4.4.6.1.1)(the last example paragraph). This definition of the rendition groups actually complies with the playlist generated by Shaka Packager,...

This could be fixed by checking the other renditions if the one we picked turned out to be non-playable, right?? I can work on this if you find it worthy.

@KarlGallagher Try adding `- scale=your_wanted_max_width:max_height` in the `filters` option in `input_config.yaml`, this will apply you scale first so the `scale='-2:{0}'.format(stream.resolution.max_height)` will have no effect at this moment.

I am trying to compile shaka-packager using these [instructions](https://github.com/shaka-project/shaka-packager/blob/main/docs/source/build_instructions.md), but getting the following error. I assume it has to do with the branch changes since the output logs mentions things...

@sr-gi > `ser_macros.rs` is based on `lightning::util::ser_macros.rs` but it significantly deviates from it. Is there any good reasoning behind it? Has `lightning::util::ser_macros.rs` been updated since you wrote this? I mainly...

> Not super used to reviewing macros but if something is not correct we will notice it when using the macros to implement the LN API. Yeah macros are tough...

In defense of `simple_logger` since it's indeed a very simple, lightweight crate: This might be a fairly [simple feature](https://github.com/borntyping/rust-simple_logger/blob/main/src/lib.rs#L452) to add.

Shouldn't changing the tower keys already disrepute the old keys since the response signature would be invalid when trying to verify it using the old pubkey (the tower failed to...