musikcube icon indicating copy to clipboard operation
musikcube copied to clipboard

Q: How to show lyrics.

Open mariocynicys opened this issue 2 years ago • 12 comments

As the title says, I am struggling know how to show the lyrics of songs. ctrl+l should be the key, but it doesn't show anything, i remapped to different keys still doesn't work, i am sure all of my songs have embedded lyrics in them, they show up on my phone. I am using version 0.96.6

Thanks in advance.

mariocynicys avatar Jul 17 '21 13:07 mariocynicys

Hmm, interesting. It may be a tag parsing issue. Are these MP3 files? Would it be possible for you to provide me with a sample song that isn't displaying lyrics, or tell me how you're adding lyrics so I can try to replicate it on my end? I believe there's more than one way to parse lyrics out of ID3v2 tags, and I wouldn't be surprised if we're not handling all the cases.

clangen avatar Jul 17 '21 19:07 clangen

Thanks for replying,

Yes most of them are MP3 files, Is there an email i can send the sample file to?

mariocynicys avatar Jul 17 '21 19:07 mariocynicys

Yep! casey [dot] langen [at] gmail [dot] com

Also, what operating system are you using? If Linux, which distribution? I'll try to setup as similar as an environment as I can when debugging.

clangen avatar Jul 17 '21 22:07 clangen

It is Ubuntu 18.04.

mariocynicys avatar Jul 18 '21 04:07 mariocynicys

Got it. I confirmed we're parsing the tag correctly, there was just a bug specific to some setups. I pushed in a fix. If you pull then build from source it should work now!

clangen avatar Jul 18 '21 20:07 clangen

Lyrics should be great. Is it a requirement to get a paid api key? With entering the free one (within the trial period) it says lyrics lookup failed... Or is there an alternative way how to get lyrics and save them in the same directory?

Distro is debian buster

r0bis avatar Sep 30 '22 19:09 r0bis

Lyrics should be great. Is it a requirement to get a paid api key? With entering the free one (within the trial period) it says lyrics lookup failed... Or is there an alternative way how to get lyrics and save them in the same directory?

Distro is debian buster

AFAIK,, the lyrics is embedded into the song file. And some files might be missing lyrics, that's why the lookup is failing.

mariocynicys avatar Sep 30 '22 19:09 mariocynicys

Sorry, was not aware that lyrics could be embedded in mp3 and flac. I assumed it was online lookup by song name and artist. AFAIK lyrics are not embedded but just stored in text files in the same directory?

r0bis avatar Sep 30 '22 19:09 r0bis

AFAIK lyrics are not embedded but just stored in text files in the same directory?

Nah, they are embedded like in the mp3 binary itself. image

IDK really how musikcube internally works, but it might be falling back to checking a lyrics file with the same name like what windows media player does with videos and subtitles or it might not be doing that, not sure.

mariocynicys avatar Sep 30 '22 21:09 mariocynicys

That is very cool. I'd like to be able to make a script that could download lyrics and write them into mp3. It should not be too difficult, if I sort out the searching in some open lyrics database.

r0bis avatar Oct 01 '22 13:10 r0bis

I'd like to be able to make a script that could download lyrics and write them into mp3.

Very neat idea, would love to see that.

mariocynicys avatar Oct 01 '22 19:10 mariocynicys

Oh, I see there's been additional discussion -- re-opening for now.

clangen avatar Dec 06 '22 05:12 clangen