Ben Mares

Results 675 comments of Ben Mares

@romain-intel, thanks so much for your persistence!!! I believe Poetry's cache was preventing you from being able to reproduce the error locally, so I modified the test to clear the...

Thanks so much @romain-intel!!! I'm slow too :see_no_evil: What do you think of this? https://github.com/romain-intel/conda-lock/pull/2 Can you think of any blockers? It'd be nice to get this merged. One last...

I don't really have time to track it down at the moment, but frustratingly I can't run pytest locally because I get: ``` conda_lock/_vendor/poetry/installation/wheel_installer.py:10: in from installer import install E...

Ya, it's weird that they have an absolute import. At first glance this really looks like a bug in Poetry if Poetry weren't controlling their own environment.

I think there's a way to patch this with `vendoring` or it's possible to apply a patch via `vendoring`

Oh! :man_facepalming: Installer is a [package](https://pypi.org/project/installer/)! I need to recreate my environment. The `installer` thing is a non-problem.

Incredible @romain-intel! I audited f43e218dc59f2d927556f1acc18a157f97b5198e because that's way too much to look at. I reproduced it exactly with the following commands: ```bash vendoring sync -vvv . dos2unix conda_lock/_vendor/poetry/core/_vendor/lark/grammars/* dos2unix conda_lock/_vendor/poetry/core/_vendor/fastjsonschema/*...

Important reference: the version pins here are incorrect and have been fixed in #678.

Thanks! I'd propose that we merge this, and then in followup PRs: 1. Also update `features/docker-in-docker/install.sh` 2. Add a GH workflow and Python script to revendor these files automatically Is...

Actually, maybe it'd be simpler to add devcontainers/features as a submodule. Then we wouldn't have to worry about keeping the individual files in sync. (Or if we want to patch...