micromamba-devcontainer icon indicating copy to clipboard operation
micromamba-devcontainer copied to clipboard

Copy latest `github.com/devcontainers/features/blob/main/src/common-utils/main.sh`

Open basnijholt opened this issue 1 year ago • 4 comments

I am debugging this container for someone using Windows where in the postStartCommand we do a pip install of the mounted repo, but get permission errors.

ATM I am just comparing what the various scripts do, and noticed this vendored script received quite a few updates.

Copied from https://github.com/devcontainers/features/blob/3ea4d6bbd7864bcf7b5a91fdeeb66e4f5a6f46c0/src/common-utils/main.sh

basnijholt avatar Dec 15 '23 18:12 basnijholt

Thanks! I'd propose that we merge this, and then in followup PRs:

  1. Also update features/docker-in-docker/install.sh
  2. Add a GH workflow and Python script to revendor these files automatically

Is there anything further you wanted to add to this?

maresb avatar Dec 16 '23 05:12 maresb

Actually, maybe it'd be simpler to add devcontainers/features as a submodule. Then we wouldn't have to worry about keeping the individual files in sync. (Or if we want to patch something, like removing lsb-release so that we don't have an extra install of Python in the base image, then it's simple to patch a copy.)

maresb avatar Dec 17 '23 01:12 maresb

@basnijholt, this dropped off my radar. Should we merge this?

maresb avatar Feb 03 '24 21:02 maresb

TBH I also kind of forgot about it 😅

I recall testing it and it worked, however, I am not 100% sure actually.

basnijholt avatar Feb 10 '24 06:02 basnijholt