Ben Mares
Ben Mares
Ah! Very good point. I guess PyPi is blindly converting underscores to dashes? It seems not so easy to search for duplicates: exponentially many possibilities in the number of underscores...
@ForgottenProgramme, exactly. For the PyPi name `very-very-long-package-name` there are 16 possible package names to check on conda-forge. But it's not a serious difficulty, just an annoyance.
Here is [a potentially really tricky case](https://github.com/conda-forge/staged-recipes/pull/14666#discussion_r618690318) where a BSD 2-clause was interpreted as a 3-clause. [Actual license file](https://github.com/sphinx-contrib/confluencebuilder/blob/master/LICENSE)
See https://github.com/conda-incubator/grayskull/pull/372. I still sort the dependencies, if it gets merged, it would be trivial to remove the `sorted()` call.
Thanks @furechan, I like the idea! A few quick technical thoughts... To implement your suggestion, we could probably simply implement `fspath()` to return the same thing as `as_uri()`, which we...
Related: a while back I submitted [a patch](https://github.com/plotly/plotly.py/issues/2753) to Plotly to make it S3Path and pathlib compatible. It was just right now released in the new v5.0, so I'm very...
@furechan, > I can confirm that fsspec does not require encoding of the s3 url. Just tried it by hand. So __fspath__() would just need to return the raw path...
I'm confused about why this issue is closed. It seems to me like there are outstanding todos here, namely to fix `.__fspath__()`. I actually like [@liormizr's original suggestion](https://github.com/liormizr/s3path/issues/59#issuecomment-775831119) the best....
My reason for why `__fspath__()` should raise an exception is that an S3Path object has no corresponding path on the local filesystem. (Similarly to how I expect `path.open().fileno()` to be...
I think @furechan summarized the situation very eloquently in his last post. I have been thinking that it might be nice to support both behaviors by having both a strict...